@ vs. $#

[pne]

I was reading a tutorial on Perl autovivification and came across this bit of code, testing whether a number was a valid array index:

return unless 0 <= $key && $key < @{$ref} ;

And I thought “meh”, because the author used @{$ref} in a comparison for a valid index.

I would have used && $key <= $#{$ref} (well, actually probably $#$ref) instead.

Because, for me, @foo (in scalar context) is the number of entries in @foo, so you’d use it for things like seeing whether you have enough arguments to a subroutine, or whether an array is empty, or that sort of thing: where you’re interested in the number of entries. $#foo, on the other hand, is the last valid index in @foo, so you’d use it when you’re interested in valid indices (indexes?) such as the comparison above or the classic for ($i = 0; $i <= $#foo; $i++) C-style for loop over the indices of an array.

Sure, the two are related to one another (@foo is one more than $#foo, unless you’ve messed with $[, which you probably shouldn’t), but for me, the two are semantically different, and using either expression in something semantically related to the other feels wrong to me.

Of course, YMMV; Perl is (at least supposedly) all about TMTOWTDI and accepting of others’ programming styles. So I’ll just say that that’s how I think of them.

Comments

[pseudomonas]

I'm with you on that one, though when I want the size of an array I tend to use scalar @foo even if @foo is in scalar context anyway. Just means I can see what I'm doing at a glance.

scalar @foo

[pne]

Good point.

[sophie]

I'm also with you; it was the first thing I thought when I saw that line of code.

[ewx]

Comparing with array size is the usual way to see if an index is in range in most languages, since Perl is somewhat unusual in having a special syntax for “last element of array”. So it doesn’t seem alien to me. It fits nicely with Dijkstra’s argument for representing array ranges as half-open intervals, too.

[pne]

Interesting; thank you.

[janinedog]

I've never in my life used the $#foo syntax--probably because I didn't know it existed until I was very set in my habits. I don't feel like I'm missing anything. :)